The 0.6.4 release bumped the MSRV to 1.88 by pinning time to 0.3.47 #40
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
acw/simple_asn1#40
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The latest 0.6.4 release implicitly bumped the MSRV to 1.88 because it pinned the time dependency to 0.3.47. The change was introduced with
github.com/acw/simple_asn1@b40a5dcd97. I am wondering whether this is strictly needed as our library is now failing to build with it's MSRV of 1.85. Alternatively, we could think about announcing the MSRV of this library. That way cargo can pick an older version of simple_asn1 that satisfies the MSRV requirements.Hey Til! Sorry about that. The update was due to a security advisory, and it doesn't look like there's a newer version to pin to. I think the best bet might be to have this library set its MSRV, then, unfortunately.
I'm also encountering this issue. Judging from the advisory though, this is only relevant if you parse with the RFC 2822 format. I'm not intimately familiar with all the edge cases ASN.1 might have, but I at least failed to find any uses of
time::format_description::well_known::Rfc2822in the code, so I'm wondering if the bump was even necessary?